Skip to content

netteForms: alert() replaced with <span class="nette-form-error"> WIP - #9

Closed
dg wants to merge 2 commits into
nette:masterfrom
dg:pull-js-error
Closed

dg wants to merge 2 commits into
nette:masterfrom
dg:pull-js-error

Conversation

@dg

@dg dg commented May 4, 2014

Copy link
Copy Markdown
Member

Moved from nette/nette#1126

@dg dg changed the title netteForms: alert() replaced with <span class="nette-form-error"> netteForms: alert() replaced with <span class="nette-form-error"> WIP Aug 7, 2014
@dg
dg force-pushed the master branch 6 times, most recently from 75b0565 to 72a5c56 Compare February 8, 2015 13:00
@dg dg added this to the v2.4 milestone Feb 16, 2015
@dg
dg force-pushed the master branch 4 times, most recently from 164ee7d to 7b7189f Compare February 18, 2015 11:04
@dg
dg force-pushed the master branch 2 times, most recently from 131f7d2 to 532059a Compare May 21, 2015 11:49
@hranicka

Copy link
Copy Markdown
Contributor

In pull request #65 I've added hooks Nette.showErrors and Nette.alert which can be overriden with custom ones. And they can show errors eg. in HTML instead of JS alert.

@dg
dg force-pushed the master branch 2 times, most recently from a57a557 to 55d0eb8 Compare June 19, 2015 12:05
@milo milo removed this from the v2.4 milestone Mar 29, 2016
@dg
dg force-pushed the master branch 2 times, most recently from 9e359e6 to fa84d63 Compare April 5, 2016 23:23
@dg
dg force-pushed the master branch 2 times, most recently from 3c1619a to 31bc0a3 Compare April 11, 2016 01:44
@dg
dg force-pushed the master branch 4 times, most recently from ec7ca6d to 0609347 Compare April 20, 2016 15:30
@dg
dg force-pushed the master branch 4 times, most recently from 81549c5 to 98832d3 Compare June 7, 2016 11:43
@dg
dg force-pushed the master branch 10 times, most recently from 802f3d4 to ed7ecd7 Compare June 30, 2016 18:18
@dg
dg force-pushed the master branch 3 times, most recently from 27d3e69 to 57295d1 Compare July 9, 2016 12:02
@dg
dg force-pushed the master branch 2 times, most recently from 5f19501 to 105a1af Compare January 4, 2017 14:16
@dg
dg force-pushed the master branch 6 times, most recently from 5de8bde to bcd9d51 Compare January 23, 2017 23:26
@diegosardina

Copy link
Copy Markdown

I'm using this since the first day I started using nette and it seems to work well.

Are there known problems? Why not merged yet since 2014?

@diegosardina

Copy link
Copy Markdown

Any chance to have this for 4.0? :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants